Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kafka.version from 3.2.3 to 3.6.0 #3434

Closed
wants to merge 2 commits into from
Closed

Bump kafka.version from 3.2.3 to 3.6.0 #3434

wants to merge 2 commits into from

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Oct 25, 2023

Same as #3429 but fixes a build issue (since 3.6 org.apache.kafka.common.serialization.Deserializer has an additional deserialize method https://github.com/apache/kafka/blob/60e845626d8a465a8cfe68bb2d7d4b88d622634e/clients/src/main/java/org/apache/kafka/common/serialization/Deserializer.java#L72)

@knative-prow knative-prow bot requested review from aliok and lionelvillard October 25, 2023 12:41
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #3434 (bbac20e) into main (ad22a19) will not change coverage.
Report is 11 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3434   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files          91       91           
  Lines        9319     9319           
=======================================
  Hits         5450     5450           
  Misses       3433     3433           
  Partials      436      436

@creydr
Copy link
Contributor Author

creydr commented Oct 25, 2023

/retest

@knative-prow
Copy link

knative-prow bot commented Oct 25, 2023

@creydr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
channel-integration-tests-sasl-ssl_eventing-kafka-broker_main bbac20e link true /test channel-integration-tests-sasl-ssl
unit-tests_eventing-kafka-broker_main bbac20e link true /test unit-tests
channel-integration-tests-ssl_eventing-kafka-broker_main bbac20e link true /test channel-integration-tests-ssl
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main bbac20e link true /test channel-reconciler-tests-sasl-ssl
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main bbac20e link true /test channel-reconciler-tests-sasl-plain
channel-reconciler-tests-ssl_eventing-kafka-broker_main bbac20e link true /test channel-reconciler-tests-ssl
integration-tests_eventing-kafka-broker_main bbac20e link true /test integration-tests
upgrade-tests_eventing-kafka-broker_main bbac20e link true /test upgrade-tests
channel-integration-tests-sasl-plain_eventing-kafka-broker_main bbac20e link true /test channel-integration-tests-sasl-plain
reconciler-tests-namespaced-broker_eventing-kafka-broker_main bbac20e link true /test reconciler-tests-namespaced-broker
reconciler-tests_eventing-kafka-broker_main bbac20e link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@creydr
Copy link
Contributor Author

creydr commented Oct 25, 2023

/hold
need to check on the failures

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023
@creydr creydr closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliok aliok Awaiting requested review from aliok

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@creydr @knative-prow-robot